-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gzip logs as per default log4j2 config #1312
Conversation
Signed-off-by: Markus Storm <markus.storm@gmx.net>
I'm fine with the changes, but we probably also want to apply them to upgrades and not only new installations. So it needs an entry for 3.2.0 in update.lst similar to:
|
I also like to keep the log4j2.xml we use in Eclipse synced with what is used in production as much as possible. So can you also update https://github.com/openhab/openhab-distro/blob/main/launch/app/runtime/log4j2.xml ? |
Signed-off-by: Markus Storm <markus.storm@gmx.net>
sorry I didn't catch that. Where would that entry need to be made ? (probably easiest when you do yourself, maintainer edit is enabled). |
Good good 👍 Just add it to 3.2.0 in the
|
Signed-off-by: Markus Storm <markus.storm@gmx.net>
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/extensive-logging-of-binding-turns-filesystem-to-read-only/147405/8 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/extensive-logging-of-binding-turns-filesystem-to-read-only/147405/20 |
Primarily to save on disk space or actually on RAM on openHABian-on-Raspi which has this in (Z)RAM
Also explicitly defined the number of logs := 7 so people know how to change that if they want to.
Fixes: openhab/openhabian#1575
Signed-off-by: Markus Storm markus.storm@gmx.net